Skip to content

[WebRTC] Rework device handling sequence so that we can handle unplugging/re-plugging devices #4593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Parent: Release/2025.07
merged 14 commits into from
Sep 13, 2025
Merged

[WebRTC] Rework device handling sequence so that we can handle unplugging/re-plugging devices #4593

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
cfbbbcf
[WebRTC] Rework device handling sequence so that we can handle unplug…
roxanneskelly Aug 21, 2025
1519e48
Fix race condition when multiple change device requests might come in…
roxanneskelly Aug 21, 2025
ac89867
Update to m137
roxanneskelly Aug 31, 2025
6ae2182
Properly pass the observer setting into the inner audio device module
roxanneskelly Sep 1, 2025
94cfc21
Update to m137 and get rid of some noise
roxanneskelly Sep 8, 2025
0f2ca29
Install nsis on windows
roxanneskelly Sep 9, 2025
71ecc8f
Use the newer digital AGC pipeline
roxanneskelly Sep 9, 2025
1312a75
Install NSIS during windows sisgning and package build step
roxanneskelly Sep 9, 2025
7fabc9e
Try pinning the packaging to windows 2022 to deal with missing nsis
roxanneskelly Sep 9, 2025
65aea52
Adjust gain calculation and audio level calculations for tuning and p…
roxanneskelly Sep 10, 2025
344b5cb
Update with mac universal webrtc build
roxanneskelly Sep 11, 2025
c4c0a6b
Tuning of voice indicators for both tuning mode and inworld for self.
roxanneskelly Sep 11, 2025
a9a18a9
Redo device deployment to handle cases where multiple deploy requests…
roxanneskelly Sep 12, 2025
faec86f
pre commit issue
roxanneskelly Sep 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/workflows/build.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,6 @@ jobs:
uses: actions/setup-python@v5
with:
python-version: "3.11"

- name: Checkout build variables
uses: actions/checkout@v4
with:
Expand Down
14 changes: 7 additions & 7 deletions autobuild.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2717,11 +2717,11 @@ Copyright (c) 2012, 2014, 2015, 2016 nghttp2 contributors</string>
<key>archive</key>
<map>
<key>hash</key>
<string>6314fdcee81a3538a7d960178ade66301c2fa002</string>
<string>43c5f93517794aeade550e4266b959d1f0cfcb7f</string>
<key>hash_algorithm</key>
<string>sha1</string>
<key>url</key>
<string>https://github.com/secondlife/3p-webrtc-build/releases/download/m114.5735.08.73-alpha/webrtc-m114.5735.08.73-alpha.11958809572-darwin64-11958809572.tar.zst</string>
<string>https://github.com/secondlife/3p-webrtc-build/releases/download/m137.7151.04.20-universal/webrtc-m137.7151.04.20-universal.17630578914-darwin64-17630578914.tar.zst</string>
</map>
<key>name</key>
<string>darwin64</string>
Expand All @@ -2731,11 +2731,11 @@ Copyright (c) 2012, 2014, 2015, 2016 nghttp2 contributors</string>
<key>archive</key>
<map>
<key>hash</key>
<string>95d7730a3d6955697e043f3fdf20ebdcc0c71fc0</string>
<string>efc5b176d878cfc16b8f82445d82ddb96815b6ab</string>
<key>hash_algorithm</key>
<string>sha1</string>
<key>url</key>
<string>https://github.com/secondlife/3p-webrtc-build/releases/download/m114.5735.08.73-alpha/webrtc-m114.5735.08.73-alpha.11958809572-linux64-11958809572.tar.zst</string>
<string>https://github.com/secondlife/3p-webrtc-build/releases/download/m137.7151.04.20-universal/webrtc-m137.7151.04.20-universal.17630578914-linux64-17630578914.tar.zst</string>
</map>
<key>name</key>
<string>linux64</string>
Expand All @@ -2745,11 +2745,11 @@ Copyright (c) 2012, 2014, 2015, 2016 nghttp2 contributors</string>
<key>archive</key>
<map>
<key>hash</key>
<string>c7b329d6409576af6eb5b80655b007f52639c43b</string>
<string>1e36f100de32c7c71325497a672fb1659b3f206d</string>
<key>hash_algorithm</key>
<string>sha1</string>
<key>url</key>
<string>https://github.com/secondlife/3p-webrtc-build/releases/download/m114.5735.08.73-alpha/webrtc-m114.5735.08.73-alpha.11958809572-windows64-11958809572.tar.zst</string>
<string>https://github.com/secondlife/3p-webrtc-build/releases/download/m137.7151.04.20-universal/webrtc-m137.7151.04.20-universal.17630578914-windows64-17630578914.tar.zst</string>
</map>
<key>name</key>
<string>windows64</string>
Expand All @@ -2762,7 +2762,7 @@ Copyright (c) 2012, 2014, 2015, 2016 nghttp2 contributors</string>
<key>copyright</key>
<string>Copyright (c) 2011, The WebRTC project authors. All rights reserved.</string>
<key>version</key>
<string>m114.5735.08.73-alpha.11958809572</string>
<string>m137.7151.04.20-universal.17630578914</string>
<key>name</key>
<string>webrtc</string>
<key>vcs_branch</key>
Expand Down
2 changes: 1 addition & 1 deletion indra/llwebrtc/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ if (WINDOWS)
iphlpapi
libcmt)
# as the webrtc libraries are release, build this binary as release as well.
target_compile_options(llwebrtc PRIVATE "/MT")
target_compile_options(llwebrtc PRIVATE "/MT" "/Zc:wchar_t")
if (USE_BUGSPLAT)
set_target_properties(llwebrtc PROPERTIES PDB_OUTPUT_DIRECTORY "${SYMBOLS_STAGING_DIR}")
endif (USE_BUGSPLAT)
Expand Down
Loading