Skip to content

Conversation

@callumlinden
Copy link
Contributor

Description

Description

This commit is focused on updating CEF to the latest version (v139 as of August 2025). This is captured in Issue #4498.

Originally this work was targeted against the Develop branch but because this work depends on the Apple Silicon work that is being tested in a separate branch, this PR is now targeted against that branch.

Note: It's not strictly true that the CEF update depends on the Apple Silicon work. The macOS Viewer with the updated CEF does work but because Chromium/CEF does not play well with Rosetta 2, it performs very (very) slowly. With the Intel/ARM builds of Dullahan that is part of the CEF update and the support for native Apple Silicon builds, things perform as well (in fact, much better) than before.

Some background about this work:

Because of significant changes to CEF in the 21 months since was last updated (v118, November 2023) there are additional changes required:

  • Prior to CEF 120, each media instance could share a set of cache directories and it worked - mostly. After version 120, this is actively prohibited. Consequently, to update CEF to v139, cache directories are now created with a unique path name.
  • Because each instance gets a brand new cache directory and the contents of each is large, the whole cef_cache folder structure is purged at startup (before the parent being created at the first media instance creation)

Known Issues

  • Nothing right now. There are a lot of moving parts are a huge number of changes so it may take some time for things to settle down.

Checklist

Please ensure the following before requesting review:

  • I have provided a clear title and detailed description for this pull request.
  • If useful, I have included media such as screenshots and video to show off my changes.
  • The PR is linked to a relevant issue with sufficient context.
  • I have tested the changes locally and verified they work as intended.
  • All new and existing tests pass.
  • Code follows the project's style guidelines.
  • Documentation has been updated if needed.
  • Any dependent changes have been merged and published in downstream modules

Additional Notes

@callumlinden callumlinden merged commit d885e73 into project/mac_universal Sep 4, 2025
22 of 27 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants