viewer-cef build fixes #4635
viewer-cef build fixes #4635
Conversation
akleshchev
force-pushed
the
andreyk/viewer_cef
branch
from
516fd75 to
af663c8
Compare
akleshchev
force-pushed
the
andreyk/viewer_cef
branch
from
11c7ffe to
7016494
Compare
Build fixes, instead of resolving unclear boost filesystem errors just updated to std in affected places.
akleshchev
force-pushed
the
andreyk/viewer_cef
branch
from
7016494 to
610bab9
Compare
akleshchev
force-pushed
the
andreyk/viewer_cef
branch
from
610bab9 to
493d7d9
Compare
There was a problem hiding this comment.
This is wrong. The lib names start with libboost for all 3 OS now.
There was a problem hiding this comment.
Old variant builds just fine on mac os (intel) but wasn't configuring on windows. I agree that logically mac should have been fine with libboost (files in the package are libboost), will try unifying.
Edit: mac fails configuration with libboost, despite libraries being libboost
| cmake_minimum_required(VERSION 3.16.0...4.0 FATAL_ERROR) | ||
| cmake_policy(SET CMP0156 NEW) | ||
| cmake_policy(SET CMP0179 NEW) | ||
| if(${CMAKE_VERSION} VERSION_GREATER_EQUAL "3.29.0") |
There was a problem hiding this comment.
The policies should probably only be set for CMake versions less than 4.0 and the minimum required CMake version should only specify a minimum version. Specifying a maximum version here is going to produce empty lines in the build output at least if using CMake 4.1.0.
There was a problem hiding this comment.
The policies should probably only be set for CMake versions less than 4.0
Why even have them in such case if they only get a narrow window (3.29..4.0) to work?
The problem was that they don't build at 3.24 nor 3.27 so I added a check to not use them (3.29 is the first implementation).
There was a problem hiding this comment.
Have you checked the content of the 3p packages? Pretty sure the lib names got unified.
There was a problem hiding this comment.
I checked the newest one. kdu.lib and libkdu.a
akleshchev
force-pushed
the
andreyk/viewer_cef
branch
2 times, most recently
from
22f8815 to
493d7d9
Compare
Build fixes to make mac and windows pass cmake stage.