p#428 'multiple textures' sometimes not present #4647
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when opening picker for the first time
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where the "Multiple textures selected" label sometimes doesn't appear when opening the texture picker for the first time. The root cause was that the commit callback from inventory was dropping 'dirty' and 'tentative' state information.
- Refactored texture/material finding logic to return inventory items directly instead of just UUIDs
- Fixed callback timing by setting selection callback after initial selection to preserve state
- Added proper handling of no-copy texture detection during initialization
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| lltexturectrl.h | Added new findInvItem method declaration and made findItemID const |
| lltexturectrl.cpp | Implemented findInvItem method, refactored initialization logic, and fixed callback timing |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
marchcat
approved these changes
Sep 9, 2025
maxim-productengine
approved these changes
Sep 9, 2025
|
Passed QA with Second Life Release 7.2.2.17688788720 (64bit) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
'Multiple textures selected' label sometimes not present when opening picker for the first time.
Commit callback from inventory was dropping 'dirty' and 'tentative'.