Fix build failing due to missing nsis #4650
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Temporary switch to windows 2022, latest 2025 doesn't have nsis
akleshchev
force-pushed
the
andreyk/viewer_build_fix
branch
from
4aa42d3 to
736a3a2
Compare
marchcat
approved these changes
Sep 9, 2025
| strategy: | ||
| matrix: | ||
| runner: ${{ fromJson((github.ref_type == 'tag' && startsWith(github.ref, 'refs/tags/Second_Life')) && '["windows-large","macos-15-xlarge"]' || '["windows-latest","macos-15"]') }} | ||
| runner: ${{ fromJson((github.ref_type == 'tag' && startsWith(github.ref, 'refs/tags/Second_Life')) && '["windows-large","macos-15-xlarge"]' || '["windows-2022","macos-15"]') }} |
Contributor
There was a problem hiding this comment.
It likely isn't needed here. But if it is, should we also change "windows-large" (for tagged builds)?
Contributor
Author
There was a problem hiding this comment.
Agree that it's likely not needed, but I just decided to switch both for now, to not get any surprises.
akleshchev
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Temporary switch to windows 2022, latest 2025 doesn't have nsis