Fix erroneous check for __attribute__ definition introduced with APR 1.7.5 #4828
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…1.7.5 With the update of APR to versoin 1.7.5., we have to deal with an erroneous check for the definition of __attribute__ added to the APR head file apr.h: The additional check for the definition of __has_attribute is nonsense as it is a C++ internal macro to check for the existance of certain attributes, however it has nothing to do with __attribute__ used in this context. Since __attribute__ is not defined in MSVC, the modified, erroneous check now causes said definition becoming missing, resulting in a huge amount of "this declaration may not have extern 'C' linkage" errors within in MSVC. This change utilizes CMake to patch the extracted APR header file, restoring the original version of the check.
Ansariel
force-pushed
the
develop-apr-header-fix
branch
from
0391bbf to
dba526f
Compare
akleshchev
approved these changes
Oct 16, 2025
marchcat
approved these changes
Oct 16, 2025
|
Thank you, merged! |
akleshchev
reviewed
Oct 16, 2025
| # Fix erroneous check for __attribute__ definition introduced with APR 1.7.5, causing lots of "this declaration may not have extern 'C' linkage" errors in VS | ||
| file(READ ${LIBS_PREBUILT_DIR}/include/apr-1/apr.h APR_HEADER_CONTENTS) | ||
| string(REPLACE "#if !(defined(__attribute__) || defined(__has_attribute))" "#if !defined(__attribute__)" APR_HEADER_CONTENTS "${APR_HEADER_CONTENTS}") | ||
| file(WRITE ${LIBS_PREBUILT_DIR}/include/apr-1/apr.h "${APR_HEADER_CONTENTS}") |
There was a problem hiding this comment.
Arguably should have been done in https://github.com/secondlife/3p-apr_suite/blob/main/build-cmd.sh
There was a problem hiding this comment.
Arguably should have been done in https://github.com/secondlife/3p-apr_suite/blob/main/build-cmd.sh
Fastest and easiest way for TPVs to get it fixed without having to wait an eternity for an updated 3p lib. 😉
This was referenced Oct 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the update of APR to versoin 1.7.5., we have to deal with an erroneous check for the definition of
__attribute__added to the APR head file apr.h: The additional check for the definition of__has_attributeis nonsense as it is a C++ internal macro to check for the existance of certain attributes, however it has nothing to do with__attribute__used in this context.Since
__attribute__is not defined in MSVC, the modified, erroneous check now causes said definition becoming missing, resulting in a huge amount of "this declaration may not have extern 'C' linkage" errors within in MSVC.This change utilizes CMake to patch the extracted APR header file, restoring the original version of the check.