Skip to content

Fix issue where mac was crashing during an attempt to unplug or replug headset. #4897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 28, 2025
+10 −4
Merged

Fix issue where mac was crashing during an attempt to unplug or replug headset. #4897

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions indra/llwebrtc/llwebrtc.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -572,14 +572,20 @@ void LLWebRTCImpl::workerDeployDevices()
void LLWebRTCImpl::setCaptureDevice(const std::string &id)
{

mRecordingDevice = id;
deployDevices();
if (mRecordingDevice != id)
{
mRecordingDevice = id;
deployDevices();
}
}

void LLWebRTCImpl::setRenderDevice(const std::string &id)
{
mPlayoutDevice = id;
deployDevices();
if (mPlayoutDevice != id)
{
mPlayoutDevice = id;
deployDevices();
}
}

// updateDevices needs to happen on the worker thread.
Expand Down