-
Notifications
You must be signed in to change notification settings - Fork 85
Update the XML files in the ja folder without changing the name attribute values of the XML files in the en folder. #713
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…bute of the XML files in the en folder.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding tabs to additional lines will show escape characters in the UI.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The nodes were already valid - no need for this change.
<check_box label="音源" name="sounds"/> | ||
<check_box label="パーティクル源" name="particles"/> | ||
<check_box label="メディアソース" name="moapbeacon"/> | ||
<check_box label="物理的" name="physical"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unnecessary changes again.
<text tool_tip="ビーコンの幅" name="beacon_width_label"> | ||
幅: | ||
</text> | ||
<slider initial_value="1" name="beacon_width"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overrides value outside text attributes.
<?xml version="1.0" encoding="utf-8" standalone="yes"?> | ||
<floater name="floater_buy_currency_html" title="通貨の購入"/> | ||
<floater name="floater_buy_currency_html" title="通貨の購入"> | ||
<floater.string name="buy_currency_url"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not language specific, therefore shouldn't be overridden.
…bute of the XML files in the en folder.
Thank you, @YuzuruJewell! |
Thank you, marchcat-pe. |
…bute of the XML files in the en folder.
…bute of the XML files in the en folder.
Thank you, Ansariel and marchcat-pe.
|
This pull request is stale because it has been open 30 days with no activity. Remove stale label or comment or it will be closed in 7 days |
Update the XML files in the ja folder without changing the name attribute values of the XML files in the en folder.
The files below could not be replaced with Japanese without changing the duplicate name attribute values using my tools.
In order to apply the Japanese translation without changing the XML files in the en folder, I temporarily changed the name attribute value of the xml files, translated the corresponding English to Japanese, and then changed it back to the original name attribute value.
I would like someone to fix the duplicate name attribute values on these files.
floater_about_land.xml
floater_beacons.xml
floater_model_preview.xml
floater_pathfinding_linksets.xml
floater_preferences_graphics_advanced.xml
floater_scene_load_stats.xml
floater_snapshot.xml
floater_test_layout_stacks.xml
floater_test_line_editor.xml
floater_test_text_editor.xml
floater_test_textbox.xml
floater_test_widgets.xml
floater_translation_settings.xml
floater_world_map.xml
fonts.xml
menu_navbar.xml
menu_settings_gear.xml
menu_topinfobar.xml
mime_types.xml
panel_group_creation_sidetray.xml
panel_notification_list_item.xml
panel_performance_preferences.xml
panel_preferences_advanced.xml
panel_preferences_sound.xml
panel_profile_pick.xml
panel_volume_pulldown.xml
sidepanel_item_info.xml