Skip to content

Conversation

@anddann
Copy link
Member

@anddann anddann commented May 14, 2019

This PR prepares the info-flow pom for deployment to Maven Central

  • add pom.xml information: developer, repository, link to github
  • change dependency versions to releases (as required by Maven Central)
  • get rid of self-created "j2ee.jar" in bin folder

add pgp-maven-plugin version

maven central: change dependency jasmin to version on maven central

migrate to dependency hosted on maven central

add basic info to pom.xml for maven central

update pom.xl properties

add snapshot to version

enter correct email
@anddann anddann requested review from StevenArzt and mbenz89 May 14, 2019 15:35
Copy link
Member

@mbenz89 mbenz89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Please fix the formatting.

@StevenArzt Note that with this configuration, the fat jar would be just built when the deploy profile is active. We do it like this for Soot since we expect our users to not require a fat jar if they want to build Soot themselves anyway.

@StevenArzt
Copy link
Member

@mbenz89 I'd rather always build the fat JAR because many FlowDroid users are not Maven experts and I have received various questions on the build process since we switched to Maven. Therefore, I'd rather build more (and accept the extra disk space and build time) to keep it simple for users.

@anddann
Copy link
Member Author

anddann commented May 15, 2019

The original assembly-plugin configuration is still contained in the default build configuration.
When someone runs mvn -DskipTests install the same jar files are generated as before this PR.
That said, IMHO there is no impact on the previous default Maven build config.

@anddann anddann requested a review from mbenz89 May 15, 2019 08:16
@StevenArzt StevenArzt merged commit d5c38d5 into master May 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants