Skip to content

Fixed callbacks in layout XML did not add to call graph bug #213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 14, 2020
Merged

Fixed callbacks in layout XML did not add to call graph bug #213

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions ...infoflow-android/src/soot/jimple/infoflow/android/callbacks/AbstractCallbackAnalyzer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -526,8 +526,12 @@ protected boolean invokesSetContentView(InvokeExpr inv) {
|| curClass.getName().equals("android.support.v7.app.ActionBarActivity")
|| curClass.getName().equals("android.support.v7.app.AppCompatActivity"))
return true;
if (curClass.declaresMethod("void setContentView(int)"))
return false;
// As long as the class is subclass of android.app.Activity,
// it can be sure that the setContentView method is what we expected.
// Following 2 statements make the overriding of method
// setContentView ignored.
// if (curClass.declaresMethod("void setContentView(int)"))
// return false;
curClass = curClass.hasSuperclass() ? curClass.getSuperclass() : null;
}
return false;
Expand Down
4 changes: 3 additions & 1 deletion soot-infoflow-android/src/soot/jimple/infoflow/android/config/SootConfigForAndroid.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,9 @@ public void setSootOptions(Options options, InfoflowConfiguration config) {
List<String> excludeList = new LinkedList<String>();
excludeList.add("java.*");
excludeList.add("sun.*");
excludeList.add("android.*");
// exclude classes of android.* will cause layout class cannot be
// loaded for layout file based callback analysis.
// excludeList.add("android.*");
excludeList.add("org.apache.*");
excludeList.add("org.eclipse.*");
excludeList.add("soot.*");
Expand Down