Skip to content

Conversation

@louison
Copy link
Contributor

@louison louison commented Sep 26, 2018

Hi, I added the ability to take alias activities into account when fetching activities from the AndroidManifest.xml file.

I also created a test and a basic APK in the repo to test the feature.

Thanks,

Louison

}

}
public void test() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this method for?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello Steven,
It was a test I forgot to delete for another feature I'm working on.
Let me fix that

@StevenArzt
Copy link
Member

Thanks a lot, that's a great merge request. I just wonder what the test() method is for. That method doesn't look like a part of the implementation, and the test case is separate anyway. Aside from that, the MR is ready for acceptance.

@louison
Copy link
Contributor Author

louison commented Sep 26, 2018

@StevenArzt I deleted the test method, sorry for that.

@StevenArzt
Copy link
Member

Thanks a lot!

@StevenArzt StevenArzt merged commit f0c5e95 into secure-software-engineering:develop Sep 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants