Convert Windows-style newline (\r\n) characters to Unix-style (\n) #146
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #:
Address theupdateframework/python-tuf#709 and theupdateframework/python-tuf#690.
Description of the changes being introduced by the pull request:
This pull request converts
\r\nnewline characters (in keys data) to\nso that consistent keyids are generated for public keys that differ only in the style of newline characters.For instance, an RSA PEM string that is generated in Windows might contain
\r\ncharacters. These newline characters would need to be read/written in a consistent manner so that the keyid of the PEM string matches the one generated on MacOS/Linux (which might treat load these newline characters as\n.Before generating the keyid of public key data (e.g., RSA PEM string), this pull request applies
replace('\r\n', '\n)to the string.Please verify and check that the pull request fulfills the following
requirements:
Signed-off-by: Vladimir Diaz <vladimir.v.diaz@gmail.com>