Skip to content

Conversation

@vladimir-v-diaz
Copy link
Contributor

Fixes issue #:

Address theupdateframework/python-tuf#709 and theupdateframework/python-tuf#690.

Description of the changes being introduced by the pull request:

This pull request converts \r\n newline characters (in keys data) to \n so that consistent keyids are generated for public keys that differ only in the style of newline characters.

For instance, an RSA PEM string that is generated in Windows might contain \r\n characters. These newline characters would need to be read/written in a consistent manner so that the keyid of the PEM string matches the one generated on MacOS/Linux (which might treat load these newline characters as \n.

Before generating the keyid of public key data (e.g., RSA PEM string), this pull request applies replace('\r\n', '\n) to the string.

Please verify and check that the pull request fulfills the following
requirements
:

  • The code follows the Code Style Guidelines
  • Tests have been added for the bug fix or new feature
  • Docs have been added for the bug fix or new feature

Signed-off-by: Vladimir Diaz <vladimir.v.diaz@gmail.com>

Signed-off-by: Vladimir Diaz <vladimir.v.diaz@gmail.com>
@vladimir-v-diaz vladimir-v-diaz merged commit 572dbe8 into secure-systems-lab:master Apr 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant