Skip to content

Conversation

@lukpueh
Copy link
Member

@lukpueh lukpueh commented Sep 30, 2020

Fixes: # -
Related to in-toto/in-toto#80

Description of the changes being introduced by the pull request:

Add convenience function to export multiple public keys from a gpg keyring into an sslib dict format at once and tests.

Note: Uses the new pseudo-standard docstring style suggested in secure-systems-lab/code-style-guidelines#20. All new interface functions should use that style (existing docstrings will be converted in separate PRs).

Please verify and check that the pull request fulfils the following requirements:

  • The code follows the Code Style Guidelines
  • Tests have been added for the bug fix or new feature
  • Docs have been added for the bug fix or new feature

@lukpueh lukpueh requested a review from joshuagl September 30, 2020 09:09
@coveralls
Copy link

coveralls commented Sep 30, 2020

Coverage Status

Coverage increased (+0.003%) to 98.952% when pulling 2aa5fef on lukpueh:add-export-gpg-pubkeys into 21ab71c on secure-systems-lab:master.

@lukpueh lukpueh force-pushed the add-export-gpg-pubkeys branch from 42171a2 to e30eadb Compare September 30, 2020 09:22
@lukpueh lukpueh requested review from SantiagoTorres and removed request for joshuagl September 30, 2020 09:49
Copy link
Collaborator

@joshuagl joshuagl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, other than a couple of minor suggestions for the docstrings. Nice change.

Add convenience function to export multiple public keys from a
gpg keyring into an sslib dict format at once and tests.

Note: Uses the new pseudo-standard docstring style suggested in
secure-systems-lab/code-style-guidelines#20. All new interface
functions should use that style (existing docstrings will be
converted in separate PRs).

Co-authored-by: Joshua Lock <jlock@vmware.com>
@lukpueh lukpueh force-pushed the add-export-gpg-pubkeys branch from ac66800 to 2aa5fef Compare September 30, 2020 13:10
@lukpueh
Copy link
Member Author

lukpueh commented Sep 30, 2020

Thanks for the quick review, @joshuagl!

@lukpueh lukpueh merged commit 8b311bf into secure-systems-lab:master Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants