This repository was archived by the owner on Oct 14, 2020. It is now read-only.
Feature/read only hooks #32
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To ensure that read-only-hooks are executed I implemented a basic integrationtest using test-scan, generic-webhook, and http-webhook. The test checks whether the logs of http-webhook contain a request.
Removed unnecessary whitespaces. Fixed indentation
I added a timeout to ensure that the logs of the http-webhook service have already been created
J12934
reviewed
Jun 25, 2020
Weltraumschaf
suggested changes
Jun 30, 2020
Member
Weltraumschaf
left a comment
Weltraumschaf
left a comment
There was a problem hiding this comment.
Please use the wording from ADR-0001.
To comply with ADR-0001 I changed the test names for Hooks.
J12934
approved these changes
Jul 8, 2020
J12934
approved these changes
Jul 8, 2020
J12934
approved these changes
Jul 8, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If applied this MR will: