Skip to content
This repository was archived by the owner on Oct 14, 2020. It is now read-only.

Conversation

@J12934
Copy link
Member

@J12934 J12934 commented Jun 29, 2020

Closes #36

This PR adds default limits and requests for the lurcher, parser and hooks.
These are currently static and cannot be changed without rebuilding the operator.

If this turns out to be ineffective this can be changed later.
Either by:

  1. Allowing to change the default at install time via the Operators helm chart
  2. Allow to override the default limits for parser and hooks in the their CRDs

The resources for the containers in which the actual scans are executed can be configured via helm.
The Charts don't provide a default value as recommended by helm (see note below):

We usually recommend not to specify default resources and to leave this as a conscious choice for the user. This also increases chances charts run on environments with little resources, such as Minikube.

@J12934 J12934 added the enhancement New feature or request label Jun 29, 2020
@J12934 J12934 changed the title Resource limits Add Resource Limits to Scans Jun 29, 2020
@Weltraumschaf Weltraumschaf merged commit 9e2a4a2 into master Jun 30, 2020
@J12934 J12934 deleted the resource-limits branch July 1, 2020 09:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add (configurable) resource limits for all scan related pods

3 participants