Skip to content
This repository was archived by the owner on Oct 14, 2020. It is now read-only.

Conversation

@Weltraumschaf
Copy link
Member

@Weltraumschaf Weltraumschaf commented Jul 13, 2020

This PR closes #50 by provides two new Architecture diagrams in the directory docs/uml:

  1. A high level component overview showing the main parts of the system and what interaction happens between them.
  2. A sequence diagram which shows a whole scan.

At the moment we didn't clarified the question which tool to use for painting digrams. Focus should be simple text based like PlantUML. But not all kinds of diagrams are feaseable with it due to autolayout issues.

This diagramm shows a very high level overview of main SCBv2
compononents and how they communicate with each other.

This diagram only shows the most important parts to be as simple
as possible. It mainly uses terms from Kubernetes because the
new architecture is completely based on Kubernetes.

The diagram (uxf) itself is editable with UMLet: https://www.umlet.com/
It isn't made with PlantUML because it was a big hassle to lign up
the boxes properly with PlantUMLs auto layouting.

The rendered image is also commited so one does not need to install
UMLet first to view it.

Signed-off-by: Sven Strittmatter <sven.strittmatter@iteratec.com>
This diagram shows the sequencial interaction of the main components
for a scan.

Note: Full arrows are syncronous calls. Half arrows areasynchronou
      calls. This is theeasier notation from UML 1.x.

The file is edited with PlatnUML: https://plantuml.com/

The rendered image is also commited so one does not need to install
UMLet first to view it.

Signed-off-by: Sven Strittmatter <sven.strittmatter@iteratec.com>
- we aonly talk about findings and not about issues
- hooks have also access to theraw result

Signed-off-by: Sven Strittmatter <sven.strittmatter@iteratec.com>
@Weltraumschaf Weltraumschaf requested review from J12934 and rfelber July 13, 2020 09:26
@Weltraumschaf Weltraumschaf added architecture documentation Improvements or additions to documentation labels Jul 13, 2020
@Weltraumschaf Weltraumschaf changed the title Closes #50 by Providing Two New Architecture Diagrams Providing Two New Architecture Diagrams Jul 13, 2020
@J12934
Copy link
Member

J12934 commented Jul 20, 2020

The diagrams by themself are great, what I'm still missing is where they should be included / linked to.
Just having them in a docs/uml folder doesn't really work.

I guess its okay to merge this now and include them later, as the user docs are currently basically a empty markdown file...

@rfelber rfelber merged commit c7ce097 into secureCodeBox:master Jul 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

architecture documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

There is no Architecutre Picture

3 participants