This repository was archived by the owner on Oct 14, 2020. It is now read-only.
Contributing #61
Merged
Contributing #61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nigthknight
commented
Jul 22, 2020
CONTRIBUTING.md
Outdated
|
|
||
| ## Code of Conduct | ||
|
|
||
| ## Code Style |
Member
Author
There was a problem hiding this comment.
We should define some basic style guidelines. For Go, we could take a look at https://github.com/kubernetes/community/blob/master/contributors/guide/coding-conventions.md
CONTRIBUTING.md
Outdated
|
|
||
| NOTE: Make sure you don't include `@mentions` or `fixes` keywords in your git commit messages. These should be included in the PR body instead. | ||
|
|
||
| ## Code Review |
Member
Author
There was a problem hiding this comment.
We should define some review guidelines. (rel. Code Style)
Member
There was a problem hiding this comment.
I would prefer code style definitons for IDE checked in because nobody wants to make this by hand nowadays.
nigthknight
commented
Jul 22, 2020
We are not sure if we need an agreement like this Until then we will remove this section
J12934
reviewed
Sep 28, 2020
ressources.md
Outdated
Comment on lines
1
to
15
| # Ressources for Contributing | ||
|
|
||
| ## Contributing | ||
|
|
||
| - [Kubernetes Contributing](https://github.com/kubernetes/community/blob/master/contributors/guide/contributing.md#learn-about-sigs) | ||
| - [Kubernetes Pull-requests](https://github.com/kubernetes/community/blob/master/contributors/guide/pull-requests.md) | ||
| - [Nodejs Contributing](https://github.com/nodejs/node/blob/master/CONTRIBUTING.md) | ||
|
|
||
| ## Code of Conduct | ||
|
|
||
| - [Kubernetes Code of Conduct](https://github.com/kubernetes/community/blob/master/governance.md#code-of-conduct) | ||
|
|
||
| ## Developer's Certificate of Origin? (Nodejs) | ||
|
|
||
| ## Rebase over Merge? (Nodejs) |
Member
There was a problem hiding this comment.
This all looks still to be WIP?
Is this intended to be changed later? If so, we should probably open up a ticket for it.
Member
Author
There was a problem hiding this comment.
Good catch! This was never meant to be committed.
J12934
approved these changes
Sep 28, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To enable Contributions by the community we need to define some standards.
This is a first WIP specification for Contributing Guidelines.