Skip to content

feat: Stricter Popup blocker #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 28, 2024
Merged

feat: Stricter Popup blocker #115

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3986b07
feat: add strict popup blocking
RKNF404 Nov 27, 2024
ee7e2ee
Merge branch 'secureblue:live' into popup-blocker
RKNF404 Nov 27, 2024
c8e41e8
feat: add flag to control behavior
RKNF404 Nov 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion patches/expose-flags.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc
index 9d0181f447a1a..8e10017c678f9 100644
--- a/chrome/browser/about_flags.cc
+++ b/chrome/browser/about_flags.cc
@@ -4220,6 +4220,36 @@ const FeatureEntry kFeatureEntries[] = {
@@ -4220,6 +4220,40 @@ const FeatureEntry kFeatureEntries[] = {
// //tools/flags/generate_unexpire_flags.py.
#include "build/chromeos_buildflags.h"
#include "chrome/browser/unexpire_flags_gen.inc"
Expand All @@ -23,6 +23,10 @@ index 9d0181f447a1a..8e10017c678f9 100644
+ "Defaults to enabled. This feature is exposed by hardened-chromium.",
+ kOsAll,
+ FEATURE_VALUE_TYPE(net::features::kCapReferrerToOriginOnCrossOrigin)},
+ {"strict-popup-blocking", "Strict Popup Blocking",
+ "Controls the strictness of the popup blocker. This switch is provided "
+ "by hardened-chromium.", kOsAll,
+ SINGLE_DISABLE_VALUE_TYPE("disable-strict-popup-blocking"},
+ {"hide-profile-icon", "Hide profile icon in toolbar",
+ "Hides the profile icon in the toolbar in regular profiles. Defaults "
+ "to enabled. This feature is provided by hardened-chromium." , kOsAll,
Expand Down
18 changes: 18 additions & 0 deletions patches/strict-popup-blocking.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
diff --git a/components/blocked_content/popup_blocker.cc b/components/blocked_content/popup_blocker.cc
index 8b12c7dd441f3..9c13ac10a6f1a 100644
--- a/components/blocked_content/popup_blocker.cc
+++ b/components/blocked_content/popup_blocker.cc
@@ -81,11 +81,8 @@ PopupBlockType ShouldBlockPopup(content::WebContents* web_contents,
return PopupBlockType::kNotBlocked;
}

- auto* safe_browsing_blocker =
- SafeBrowsingTriggeredPopupBlocker::FromWebContents(web_contents);
- if (safe_browsing_blocker &&
- safe_browsing_blocker->ShouldApplyAbusivePopupBlocker(
- GetSourcePageForPopup(open_url_params, web_contents))) {
+ if (!base::CommandLine::ForCurrentProcess()->HasSwitch(
+ "disable-strict-popup-blocking")) {
return PopupBlockType::kAbusive;
}
return PopupBlockType::kNotBlocked;