Skip to content

Conversation

@RKNF404
Copy link
Collaborator

@RKNF404 RKNF404 commented Jul 20, 2024

Enables some partitioning features, relating to memory cache and :visited link databases.
Also updates the Vanadium partitioning patch, since most of the features it enables don't exist anymore.

@RKNF404 RKNF404 requested a review from RoyalOughtness as a code owner July 20, 2024 02:13
@RKNF404
Copy link
Collaborator Author

RKNF404 commented Jul 20, 2024

Checked with Vanadium. See the issue for partitioning, I guess I misunderstood. Seems like it will be true eventually, since it isn't stable yet? Not sure. Seems worth keeping an eye on. As for :visited link partitioning, it's being consider. I'll close this PR, since there isn't much to add.

@RKNF404 RKNF404 closed this Jul 20, 2024
@RoyalOughtness
Copy link
Contributor

@RKNF404 I think we can still add the visited partitioning? GrapheneOS/Vanadium#568 (comment)

@RKNF404
Copy link
Collaborator Author

RKNF404 commented Jul 20, 2024

Add it before Vanadium? Or do we want to stay synced with Vanadium patches?

@RoyalOughtness
Copy link
Contributor

We can add it before. We don't have to stay "synced" per se but we can give them a heads up when we find stuff that's common between the two projects

@RKNF404
Copy link
Collaborator Author

RKNF404 commented Jul 20, 2024

Ok, just wanted to gage your position on that. Do you want to reopen this then and remove the uneeded patches?

@RKNF404
Copy link
Collaborator Author

RKNF404 commented Jul 20, 2024

I'll get to this Sunday evening (EST), currently without computer.

@RoyalOughtness
Copy link
Contributor

@RKNF404 for sure! it's foss, there's no rush 😄

@RKNF404
Copy link
Collaborator Author

RKNF404 commented Jul 22, 2024

Only one patch should be added here for :visited link partitioning. Vanadium did enable it as well, but they are essentially the same patch.

@RKNF404
Copy link
Collaborator Author

RKNF404 commented Jul 22, 2024

I opted to avoid scoped memory cache for now, I'll read more about it later.

@RoyalOughtness
Copy link
Contributor

@RKNF404 yeah makes sense, can you add it to the spec patch as well and then I'll merge this, thanks

@RKNF404
Copy link
Collaborator Author

RKNF404 commented Jul 22, 2024

Alright, I think that should work now?

@RoyalOughtness
Copy link
Contributor

RoyalOughtness commented Jul 22, 2024

Alright, I think that should work now?

almost, you included the patch but didn't set it to run. See line 250

@RKNF404
Copy link
Collaborator Author

RKNF404 commented Jul 22, 2024

Ok, I believe this is it right?

@RoyalOughtness
Copy link
Contributor

looks good. can you also set:

Release: 3%{?dist}

then i'll merge and rebuild

@RKNF404
Copy link
Collaborator Author

RKNF404 commented Jul 22, 2024

Release has been incremented

@RoyalOughtness RoyalOughtness merged commit c1a4a2a into secureblue:master Jul 22, 2024
@RKNF404 RKNF404 deleted the changes-1 branch April 10, 2025 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants