-
-
Notifications
You must be signed in to change notification settings - Fork 18
feat: Remove reference to removed preferences #63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This looks good, the only issue is that it won't be localized, so non-english users will see these strings as english instead of other langs. Let me look into how chromium handles localization, we could potentially do it ourselves or reuse existing strings |
|
May be possible by updating the variables here instead of the HTML directly. Since the previous code automatically localizes the variable used. Tried doing something similar to this previously to no avail. |
|
@RKNF404 The localization is automatic only in the sense that the localized files are generated and stored in code. If you add new strings, they won't automatically be localized. Have a look at this: https://www.chromium.org/developers/design-documents/ui-localization/ That being said, I think we could potentially reuse existing strings. For example, if we go with "Profile" instead of "Your Profile": |
|
@qoijjj
Sure, whatever works best. |
|
@RKNF404 we could remove the subtext altogether? could look a bit ugly though idk. |
|
@RKNF404 yeah, yucky 😄 |
|
looks like it's used inside of privacyguides, so it shouldn't be going away anytime soon 😄 |
|
@qoijjj For profile, I can't find the string for just "Profile", what about "Profile information"? https://source.chromium.org/chromium/chromium/src/+/main:chrome/app/profiles_strings.grdp;l=631?q=profile%3C%20.grdp |
|
@RKNF404 works for me |
|
@qoijjj Did the thing, it isnt tested but should work. |
|
Doesn't work currently. Potential cause of crashes when opening settings pages. |
This reverts commit 15625f6.
This reverts commit 15625f6.

Closes #61
Closes #62