Skip to content

Conversation

@RKNF404
Copy link
Collaborator

@RKNF404 RKNF404 commented Sep 5, 2024

Closes #61
Closes #62

@RoyalOughtness
Copy link
Contributor

This looks good, the only issue is that it won't be localized, so non-english users will see these strings as english instead of other langs. Let me look into how chromium handles localization, we could potentially do it ourselves or reuse existing strings

@RKNF404
Copy link
Collaborator Author

RKNF404 commented Sep 8, 2024

May be possible by updating the variables here instead of the HTML directly. Since the previous code automatically localizes the variable used. Tried doing something similar to this previously to no avail.

@RoyalOughtness
Copy link
Contributor

@RKNF404 The localization is automatic only in the sense that the localized files are generated and stored in code. If you add new strings, they won't automatically be localized. Have a look at this: https://www.chromium.org/developers/design-documents/ui-localization/

That being said, I think we could potentially reuse existing strings. For example, if we go with "Profile" instead of "Your Profile":

https://source.chromium.org/chromium/chromium/src/+/main:third_party/libaddressinput/src/externals/grit/grit/testdata/generated_resources_fr.xtb;l=1442?q=5542132724887566711&ss=chromium&start=81

@RKNF404
Copy link
Collaborator Author

RKNF404 commented Sep 9, 2024

@qoijjj

If you add new strings, they won't automatically be localized.

we go with "Profile" instead of "Your Profile"

Sure, whatever works best.
The only problem I see is with the safe browsing reference, not a major issue but not sure if any other string fits in that position.
The other string I modified isn't an issue either.

@RoyalOughtness
Copy link
Contributor

RoyalOughtness commented Sep 9, 2024

@RKNF404 we could remove the subtext altogether? could look a bit ugly though idk.

@RKNF404
Copy link
Collaborator Author

RKNF404 commented Sep 9, 2024

@qoijjj

What do you think of this? Personally, not very clean.
image

@RoyalOughtness
Copy link
Contributor

@RKNF404 yeah, yucky 😄

@RKNF404
Copy link
Collaborator Author

RKNF404 commented Sep 9, 2024

@RoyalOughtness
Copy link
Contributor

@RKNF404
Copy link
Collaborator Author

RKNF404 commented Sep 9, 2024

@qoijjj

For profile, I can't find the string for just "Profile", what about "Profile information"? https://source.chromium.org/chromium/chromium/src/+/main:chrome/app/profiles_strings.grdp;l=631?q=profile%3C%20.grdp

@RoyalOughtness
Copy link
Contributor

@RKNF404 works for me

@RKNF404
Copy link
Collaborator Author

RKNF404 commented Sep 9, 2024

@qoijjj Did the thing, it isnt tested but should work.

@RKNF404
Copy link
Collaborator Author

RKNF404 commented Sep 9, 2024

Doesn't work currently. Potential cause of crashes when opening settings pages.

@RoyalOughtness RoyalOughtness merged commit 15625f6 into secureblue:master Sep 10, 2024
RKNF404 added a commit to RKNF404/Trivalent that referenced this pull request Sep 10, 2024
RKNF404 added a commit to RKNF404/Trivalent that referenced this pull request Sep 10, 2024
RoyalOughtness pushed a commit that referenced this pull request Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cosmetic issue: profile settings doesn't need to mention google Cosmetic issue: security settings still mentions safe browsing

2 participants