Skip to content

fix: int cells were not supported in dataSet format #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 24, 2018
Merged

fix: int cells were not supported in dataSet format #53

merged 2 commits into from
Sep 24, 2018

Conversation

@boazadato
Copy link
Contributor

@boazadato boazadato commented May 16, 2018

in dataSet format,{value: 3} is being used to set the cell value.
internally, for this object format cell type (cell.t) was not set

@securedeveloper securedeveloper self-assigned this May 18, 2018
@nhancdt nhancdt mentioned this pull request Jul 14, 2018
Closed
@securedeveloper securedeveloper merged commit d65eeb3 into securedeveloper:master Sep 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@juanpicado juanpicado Awaiting requested review from juanpicado

@securedeveloper securedeveloper Awaiting requested review from securedeveloper

Assignees

@boazadato boazadato

@securedeveloper securedeveloper

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@boazadato @securedeveloper