Skip to content

Conversation

@red-hat-konflux
Copy link

@red-hat-konflux red-hat-konflux bot commented May 10, 2025

Build pipeline Service Account migration

This PR changes Service Account used by build pipeline from "appstudio-pipeline" to dedicated to the Component Service Account.
Please merge the Service Account update to avoid broken builds when deprected "appstudio-pipeline" Service Account is removed.

Summary by Sourcery

Chores:

  • Update Tekton pipeline configuration to use a new service account

Signed-off-by: konflux <konflux@no-reply.konflux-ci.dev>
@sourcery-ai
Copy link

sourcery-ai bot commented May 10, 2025

Reviewer's Guide

This PR updates the Tekton pipeline definitions (.tekton/gitsign-pull-request.yaml and .tekton/gitsign-push.yaml) to introduce 'build-pipeline-gitsign' as the default service account by populating the taskRunTemplate.serviceAccountName field. Notably, the 'run-unit-test' task within taskRunSpecs is explicitly configured to continue using the older 'appstudio-pipeline' service account. The changes also encompass minor configuration normalizations, including parameter type adjustments and reordering of YAML sections for consistency.

File-Level Changes

Change Details Files
Updated service account configurations in Tekton pipelines.
  • Set 'build-pipeline-gitsign' as the default serviceAccountName in the taskRunTemplate section.
  • The 'run-unit-test' task, specified under taskRunSpecs, continues to explicitly use 'appstudio-pipeline' as its serviceAccountName.
.tekton/gitsign-pull-request.yaml
.tekton/gitsign-push.yaml
Normalized pipeline parameters and YAML structure.
  • Converted the go_unit_test parameter value from boolean true to the string "true".
  • Reformatted the pipelinesascode.tekton.dev/on-cel-expression metadata annotation for readability.
  • Reordered the pipelineRef and taskRunSpecs sections within the pipeline definitions.
.tekton/gitsign-pull-request.yaml
.tekton/gitsign-push.yaml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@openshift-ci
Copy link

openshift-ci bot commented May 12, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: red-hat-konflux[bot], tommyd450

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tommyd450 tommyd450 merged commit 4f7b235 into main May 12, 2025
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant