fix: 🐛 filter out path and data errors correctly #134
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martonvago
commented
Oct 15, 2025
Contributor
Author
There was a problem hiding this comment.
What this function should do:
- only remove the parent error if there are other errors in the group
- if both
dataandpathare missing on the resource, unite those two errors into a single better error - remove all
data/pathrequired errors (whether there are two errors or just one)
martonvago
commented
Oct 15, 2025
Comment on lines
+194
to
+204
| def test_fail_with_only_resource_name_missing(): | ||
| descriptor = example_package_descriptor() | ||
| del descriptor["resources"][0]["name"] | ||
|
|
||
| issues = check(descriptor) | ||
|
|
||
| assert len(issues) == 1 | ||
| assert issues[0].jsonpath == "$.resources[0].name" | ||
| assert issues[0].type == "required" | ||
|
|
||
|
|
Contributor
Author
There was a problem hiding this comment.
This was failing because the name missing makes jsonschema check against both the path-based and data-based schemas, resulting in a "data is missing" issue.
But we know that, because the path is present here, we should only be checking against the path-based schema.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I refactored this wrong, sorry, fixing it here.
Needs a quick review.
Checklist
just run-all