feat: ✨ support union operator in RequiredCheck
#201
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martonvago
commented
Nov 19, 2025
martonvago
commented
Nov 19, 2025
martonvago
commented
Nov 19, 2025
martonvago
commented
Nov 19, 2025
martonvago
commented
Nov 19, 2025
martonvago
commented
Nov 19, 2025
martonvago
commented
Nov 19, 2025
martonvago
commented
Nov 19, 2025
martonvago
commented
Nov 19, 2025
martonvago
commented
Nov 19, 2025
lwjohnst86
requested changes
Nov 20, 2025
Member
lwjohnst86
left a comment
lwjohnst86
left a comment
There was a problem hiding this comment.
Awesome possum 🐰 some small edits
github-project-automation
bot
moved this from In Review
to In Progress
in Iteration planning
Co-authored-by: Luke W. Johnston <lwjohnst86@users.noreply.github.com>
…ct/check-datapackage into feat/required-check-union
lwjohnst86
approved these changes
Nov 20, 2025
github-project-automation
bot
moved this from In Review
to In Progress
in Iteration planning
github-project-automation
bot
moved this from In Progress
to Done
in Iteration planning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for the union JSON path operator for
RequiredChecks.To be able to do this more intelligently than a monster regex, I looked into how
jsonpathrepresents a JSON path internally and used their terms/classification. This also allowed me to be more precise about what JSON paths we are not allowing forRequiredChecks.Closes #193
Needs an in-depth review.
Checklist
just run-all