-
Notifications
You must be signed in to change notification settings - Fork 0
docs: ✨ add landing page #79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
lwjohnst86
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! 😁 very minor edit
Co-authored-by: Luke W. Johnston <lwjohnst86@users.noreply.github.com>
lwjohnst86
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just change to descriptor and add your comments, then I'll approve 👍
martonvago
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nicely written! Just super minor things
Suggestion by @martonvago Co-authored-by: martonvago <57952344+martonvago@users.noreply.github.com>
lwjohnst86
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Just some small comments 👍
Apply suggestion from @lwjohnst86 Co-authored-by: Luke W. Johnston <lwjohnst86@users.noreply.github.com>
Apply suggestion from @signekb
Description
This adds a landing page to the website. This is a first draft and I'm a bit out of touch with this package, so let me know if something's off :)
Closes #8
Needs an in-depth review.
Checklist
just run-all