Skip to content

Conversation

@lwjohnst86
Copy link
Member

Description

Add decision post on why to switch to pytest.

Closes #101, see also seedcase-project/seedcase-sprout#226

Reviewer Focus

This PR needs a bit of a review.

Checklist

  • Ran spell-check
  • Formatted Markdown
  • Rendered website locally

@lwjohnst86 lwjohnst86 requested a review from a team as a code owner July 17, 2024 14:32
@lwjohnst86 lwjohnst86 enabled auto-merge (squash) July 17, 2024 14:35
Copy link
Contributor

@martonvago martonvago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍 👍

Copy link
Member

@signekb signekb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! I have some suggestions 🚀

all tests need to be a `class` object and some testing needs
`setUp()` and `tearDown()` methods.
- The test output is not very readable and beginner friendly.
- Creating tests takes more effort and time.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

more effort and time as compared to what? :)

Co-authored-by: Signe Kirk Brødbæk <40836345+signekb@users.noreply.github.com>
Co-authored-by: martonvago <57952344+martonvago@users.noreply.github.com>
@lwjohnst86 lwjohnst86 requested review from martonvago and signekb July 29, 2024 16:28
@lwjohnst86 lwjohnst86 disabled auto-merge August 5, 2024 14:43
@lwjohnst86 lwjohnst86 merged commit b66138c into main Aug 5, 2024
@lwjohnst86 lwjohnst86 deleted the docs/post-on-pytest branch August 5, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Write decision post on using pytest

4 participants