build: ➕ add vulture to dev with just recipe to check for unused code
#1330
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
signekb
changed the title
vulture to dev with just recipe vulture to dev with just recipe
signekb
changed the title
vulture to dev with just recipe vulture to dev with just recipe to check for unused code
Member
Author
|
When this has been reviewed and merged, I’ll add it to |
lwjohnst86
approved these changes
May 14, 2025
Member
lwjohnst86
left a comment
lwjohnst86
left a comment
There was a problem hiding this comment.
Nice! You can add it to the workflow in .github repo easily because the workflow uses the just recipe.
lwjohnst86
pushed a commit
to seedcase-project/.github
that referenced
this pull request
May 14, 2025
## Description This PR adds the `just check-unused` recipe to the reusable build workflow. As noted here: seedcase-project/seedcase-sprout#1330 (review) <!-- Please delete as appropriate: --> This PR needs a quick/an in-depth review.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds
vultureto ourdevdependencies and ajustrecipe that uses vulture to check for unused code in thesrc/andtests/directories.The
check-unusedrecipe is also added torun-all.I thought it made sense to the check for unused code add it as a
just recipeinstead of e.g., a workflow, but let me know if you agree or not 😁Closes #1223
This PR needs an in-depth review.
Checklist
just run-all