This repository was archived by the owner on Nov 23, 2019. It is now read-only.
save cross domain identifier cookies from the server as an option #56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fathyb
approved these changes
Jun 12, 2019
lib/index.js
Outdated
| var xhr = new XMLHttpRequest(); | ||
| xhr.open('GET', url, true); | ||
| xhr.withCredentials = true; | ||
| xhr.send(); |
Contributor
There was a problem hiding this comment.
Should we handle XHR errors?
Contributor
Author
There was a problem hiding this comment.
Yeah I think so - I'm going to update it so that the localStorage value is only set once the HTTP request completes.
lib/index.js
Outdated
|
|
||
| var cachedCrossDomainId = this.getCachedCrossDomainId(); | ||
| if (cachedCrossDomainId) { | ||
| callback(null, { |
Contributor
There was a problem hiding this comment.
Should we do if(callback) here?
we've verified that the legacy cookies are not in use anymore, hence we can get rid of this migration logic to simplify the client side code. here's a link to the same change we made on the server (internal link) https://github.com/segmentio/xid/pull/12.
Previously xid metadata was stored as client side cookies. This change allows us to set the cookies from a server as httpOnly cookies. We also store the identifier in localStorage To allow the current domain to read it from javascript. This is only set if the request completes succesfully. This behaviour is behind a flag `saveCrossDomainIdInLocalStorage` that is off by default. This also removes some of the metadata that we don't use (such as the domain of the cookie and timestamp of the cookie)
fathyb
approved these changes
Jun 18, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously cross domain analytics metadata was stored as client side cookies. This change allows us to set the cookies from a server as httpOnly cookies. We also store the identifier in localStorage To allow the current domain to read it from javascript. This behaviour is behind a flag
saveCrossDomainIdInLocalStoragethat is off by default.This also removes some of the extraneous metadata that we don't use (such as the domain of the cookie and timestamp of the cookie), and also removes code to migrate legacy cookies.