feat(ios): set trackAdvertising=true by default on ios (#82)

Kadi Kraman · f2prateek · commit 09e997b22504 · 2019-06-17T09:16:39.000-07:00
diff --git a/packages/core/docs/classes/analytics.client.md b/packages/core/docs/classes/analytics.client.md
@@ -142,7 +142,7 @@ ___
 
 ▸ **getAnonymousId**(): `Promise`<`string`>
 
-*Defined in [analytics.ts:305](https://github.com/segmentio/analytics-react-native/blob/master/packages/core/src/analytics.ts#L305)*
+*Defined in [analytics.ts:307](https://github.com/segmentio/analytics-react-native/blob/master/packages/core/src/analytics.ts#L307)*
 
 Retrieve the anonymousId.
 
diff --git a/packages/core/src/__tests__/configuration.spec.ts b/packages/core/src/__tests__/configuration.spec.ts
@@ -26,7 +26,7 @@ it('uses the default configuration', async () => {
 				flushInterval: undefined
 			},
 			ios: {
-				trackAdvertising: false,
+				trackAdvertising: true,
 				trackDeepLinks: false
 			}
 		})
diff --git a/packages/core/src/analytics.ts b/packages/core/src/analytics.ts
@@ -51,8 +51,8 @@ export module Analytics {
 		ios?: {
 			/**
 			 * Whether the analytics client should track advertisting info.
-			 * 
-			 * Disabled by default.
+			 *
+			 * Enabled by default.
 			 */
 			trackAdvertising?: boolean
 			/**
diff --git a/packages/core/src/configuration.ts b/packages/core/src/configuration.ts
@@ -10,7 +10,7 @@ const defaults = {
 		flushInterval
 	}),
 	ios: ({
-		trackAdvertising = false,
+		trackAdvertising = true,
 		trackDeepLinks = false
 	}: Partial<Configuration['ios']>) => ({
 		trackAdvertising,

Original file line number	Diff line number	Diff line change
`@@ -26,7 +26,7 @@ it('uses the default configuration', async () => {`
`26`	`26`	`flushInterval: undefined`
`27`	`27`	`},`
`28`	`28`	`ios: {`
`29`		`- trackAdvertising: false,`
	`29`	`+ trackAdvertising: true,`
`30`	`30`	`trackDeepLinks: false`
`31`	`31`	`}`
`32`	`32`	`})`