Skip to content

Conversation

@oscb
Copy link
Contributor

@oscb oscb commented Sep 8, 2023

  • Splits the logic of stamping userInfo and context out from applyRawEventData. This is required as the raw event data should only be basic data: timestamp and messageId that can be calculated from the start, the userInfo and context should wait for the initialization to finish

    • This caused a bug where events triggered at the very start of the app, just before initialization would not contain either userInfo or context
    • Added tests
  • Removed info.ts from the build as it is auto generated on build

Copy link
Contributor

@alanjcharles alanjcharles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@oscb oscb merged commit c220376 into master Sep 12, 2023
@oscb oscb deleted the oscb/process branch September 12, 2023 18:33
oscb pushed a commit that referenced this pull request Sep 14, 2023
## [@segment/analytics-react-native-v2.16.1](https://github.com/segmentio/analytics-react-native/compare/@segment/analytics-react-native-v2.16.0...@segment/analytics-react-native-v2.16.1) (2023-09-14)

### Bug Fixes

* split userInfo/context stamping from raw event data ([#876](#876)) ([c220376](c220376))
@oscb
Copy link
Contributor Author

oscb commented Sep 14, 2023

🎉 This PR is included in version @segment/analytics-react-native-v2.16.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@oscb oscb added the released label Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants