hopefully fix, require changelog for publish

Author: danieljackins

.circleci/changelog-check.sh

@@ -9,11 +9,11 @@ SITE_CHANGES=$(git diff "$BRANCH".."$REMOTE" | wc -l)
 echo "Detected $SITE_CHANGES changes"
 if [ "$SITE_CHANGES" -gt "0" ]; then
   echo "Checking to make sure package version was updated..."
-  VERSION_CHANGED=$(git diff "$BRANCH".."$REMOTE" -G '"version":' -- $REPO_ROOT/package.json | wc -l)
-  if [ "$VERSION_CHANGED" -gt "0" ]; then
-    echo "Version was updated!  Continuing..."
+  HISTORY_CHANGED=$(git diff "$BRANCH".."$REMOTE" -- $REPO_ROOT/HISTORY.md | wc -l)
+  if [ "$HISTORY_CHANGED" -gt "0" ]; then
+    echo "History was updated!  Continuing..."
   else
-    echo "Version was not updated :( Aborting push."
+    echo "History was not updated :( Aborting push."
     exit 1
   fi
 fi

.circleci/config.yml

@@ -5,11 +5,6 @@ defaults: &defaults
 
 version: 2
 jobs:
-  changelog:
-    <<: *defaults
-    steps:
-      - checkout
-      - run: make release-test
   test:
     <<: *defaults
     steps:
@@ -54,6 +49,12 @@ jobs:
       - run: yarn run snyk test --severity-threshold=high
       - run: yarn run snyk monitor
 
+  changelog:
+    <<: *defaults
+    steps:
+      - checkout
+      - run: make release-test
+
   publish:
     <<: *defaults
     steps:
@@ -74,8 +75,6 @@ workflows:
           filters:
             tags:
               only: /.*/
-          requires:
-            - changelog
       - coverage:
           filters:
             tags:
@@ -87,6 +86,7 @@ workflows:
       - publish:
           requires:
             - test
+            - changelog
           filters:
             tags:
               only: /v[0-9]+(\.[0-9]+)*(-.+)?/