Add option to use amplitude referral behaviour #639
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danieljackins
requested review from
juliofarah,
mshwery,
nettofarah and
pooyaj
pooyaj
approved these changes
Oct 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
In this PR #73, we stopped using Amplitudes includeReferrer setting in order to avoid a bug with anonymousIds. However, this broke the option to only set a referrer once per session, as our integration has no concept of amplitudes sessions. Referrers are being set with every page even when the option to only set referrer once per session is enabled.
This PR adds an option to revert to the old behaviour, where we let Amplitude handle setting referrer once per session. The default of the option will be a non-breaking change for existing users.
Are there breaking changes in this PR?
No
Testing
Testing completed successfully locally (referrer not being overwritten):
Any background context you want to provide?
Is there parity with the server-side/android/iOS integration components (if applicable)?
Does this require a new integration setting? If so, please explain how the new setting works
Yes, explained above
Links to helpful docs and other external resources