Skip to content

Conversation

@marinhero
Copy link
Contributor

@marinhero marinhero commented Oct 21, 2021

What does this PR do?

Checks if the Marketo global objects are defined and gracefully ends execution of the Segment calls if the objects are not defined.

Are there breaking changes in this PR?

No.

Testing

  • Testing completed successfully using localhost using the sources compiler pointing to a Stage source.

Screen Shot 2021-11-01 at 3 51 00 PM

Screen Shot 2021-11-01 at 3 57 27 PM

Any background context you want to provide?

https://segment.atlassian.net/jira/software/c/projects/STRATCONN/boards/310?modal=detail&selectedIssue=STRATCONN-973

@marinhero marinhero force-pushed the marin/munchkin-test branch from 2e439bc to 5fe2537 Compare October 21, 2021 17:10
@marinhero marinhero force-pushed the marin/munchkin-test branch from 5fe2537 to ca5afa1 Compare October 26, 2021 21:43
@marinhero marinhero merged commit 436be26 into master Nov 9, 2021
@marinhero marinhero deleted the marin/munchkin-test branch November 9, 2021 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants