Skip to content

Conversation

@danieljackins
Copy link
Contributor

What does this PR do?
This PR fixes the misspelled VWO setting, "trackOnlyAbExperiments"
image
(from #633)
Are there breaking changes in this PR?
N/A

Testing
Testing not required, fixing broken setting with typo
--->

Any background context you want to provide?

Is there parity with the server-side/android/iOS integration components (if applicable)?

Does this require a new integration setting? If so, please explain how the new setting works

Links to helpful docs and other external resources

@danieljackins danieljackins merged commit 7461634 into master Nov 10, 2021
@danieljackins danieljackins deleted the vwo-setting-fix branch November 10, 2021 19:42
@nitishmittal17
Copy link

Hi team,

Thanks for approving the changes and merging the PR. We can see the code merged, but the changes are not reflecting in the analytics.min.js file. We are checking this file:
https://cdn.segment.com/analytics.js/v1/bQYubnZqEXrCQkFTXwoH49aOL92KKsDz/analytics.min.js

Can you please check this once?

cc @juliofarah @danieljackins @pooyaj

Regards,
Nitish

@danieljackins danieljackins mentioned this pull request Nov 17, 2021
@danieljackins
Copy link
Contributor Author

Hey @nitishmittal17 we'll get this rolled out. You should see the changes reflected by early next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants