Skip to content

Conversation

@mdellanoce
Copy link
Contributor

@mdellanoce mdellanoce commented Nov 18, 2022

What does this PR do?

Pendo will be initialized with segment's current user and group information, instead of using a randomly generated Pendo user for the initial events.

Are there breaking changes in this PR?

No

Testing

Testing completed successfully. Added unit tests, and tested manually in the tester application in the integrations repo.

Any background context you want to provide?

Is there parity with the server-side/android/iOS integration components (if applicable)?

N/A

Does this require a new integration setting? If so, please explain how the new setting works

No

Links to helpful docs and other external resources

Copy link
Contributor

@arielsilvestri arielsilvestri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@arielsilvestri
Copy link
Contributor

Hey @mdellanoce, could you update your branch with latest master? I'll get this merged in once that's done. Thanks!

@mdellanoce
Copy link
Contributor Author

@arielsilvestri done

@arielsilvestri arielsilvestri changed the base branch from master to pendo-race-condition December 6, 2022 16:55
@arielsilvestri arielsilvestri merged commit 8baf25b into segmentio:pendo-race-condition Dec 6, 2022
arielsilvestri added a commit that referenced this pull request Dec 6, 2022
Co-authored-by: Michael Dellanoce <michael.dellanoce@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants