Skip to content

Changing Button CSS proptype order #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jeroenransijn merged 2 commits into from
Feb 12, 2018
Merged

Changing Button CSS proptype order #133

jeroenransijn merged 2 commits into from
Feb 12, 2018

Conversation

@fforres
Copy link
Contributor

@fforres fforres commented Feb 12, 2018 •
edited
Loading

Could not override the buttons css on evergreen, (not sure if it's the desired behaviour).

This PR

  • In Button component, changes css proptype order so it can override the props being set up by appearanceStyle

@jeroenransijn
Copy link
Contributor

jeroenransijn commented Feb 12, 2018

Looks good. Might change this in a breaking way in the future when we have theming support — which will be a major version change.

@jeroenransijn jeroenransijn merged commit 596d219 into master Feb 12, 2018
@jeroenransijn jeroenransijn deleted the fforres/css branch February 12, 2018 22:07
prateekgoel pushed a commit to prateekgoel/evergreen that referenced this pull request Oct 26, 2018
@fforres @jeroenransijn
Changing Button CSS proptype order (segmentio#133)
f48c9b1 
* Changing proptype precedence

* fix eslint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jeroenransijn jeroenransijn Awaiting requested review from jeroenransijn

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@fforres @jeroenransijn