React 18 support #1458
Merged
React 18 support #1458
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…React 18 by default
This reverts commit 109ee01.
brandongregoryscott
added
the
dependencies
✅ Deploy Preview for evergreen-storybook ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Contributor
Author
|
Drafting this - until we update the way we're rendering rendering the Tooltip w/ the new recommended |
| test('<Text /> has undefined behavior when trying to set arbitrary sizes', () => { | ||
| render(<Text size={800} />) | ||
| expect(mockFn.mock.calls.length).toEqual(1) | ||
| expect(mockFn.mock.calls.length).toBeGreaterThanOrEqual(1) |
Contributor
Author
There was a problem hiding this comment.
The warning from ReactDOM.render added an additional call here 🤦
…rgreen into react-18-support
krousseau
approved these changes
Jun 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Resolves #1453
I wanted to move the two
@typespackages that are in our production dependency list, but I'm honestly not sure how to test to see if they are required for ourindex.d.tsyet (i.e. if anything breaks for an end-user if we don't ship with those types). I imagine if those types are needed because we're referencing them in some of our own type definitions, we could specify@types/reactas a peer dependency instead, but that might be a problem for another day.I pulled in a local version of the package in
appand it seems to run fine (no console warning since we're on an older version of React).In a React v18 app, it will still produce the warning for now.
Screenshots (if applicable)
Documentation