Test against multiple Kafka versions #186
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pryz
force-pushed
the
ci-test-multiple-kafka-version
branch
from
a4c2a0f to
19f0a14
Compare
achille-roussel
approved these changes
Jan 28, 2019
Contributor
achille-roussel
left a comment
achille-roussel
left a comment
There was a problem hiding this comment.
Really cool initiative 👍
I find it a bit strange that tests pass against Kafka 2 because we had a couple of reports from people that had troubles working with this version... maybe our tests aren't exercising some edge cases on v2.
Contributor
Author
|
Yes I was pretty surprise as well but there is not that many protocol changes between 1.x and 2.x. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kafka-gois getting more and more contributors using multiple versions of Kafka. To ensure proper compatibility with the supported versions, we need to test against all of them.This PR creates a CI job for Kafka 0.11.0.1, 1.1.1 and 2.1.0.