Clean up validation, add OPA support #37
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 158fee7.
dk1027
approved these changes
Apr 9, 2021
Contributor
dk1027
left a comment
dk1027
left a comment
There was a problem hiding this comment.
Just a minor comment on StatusOther --- maybe it should return an error/warning instead?
|
Are we able to work with policies in CI ? |
Contributor
Author
|
@Pryz yup, that's coming in a follow-up. This change doesn't define any policies, it just adds the basic checking capability into kubeapply. |
Pryz
approved these changes
Apr 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change includes several updates to how
kubeapply validateworks:kubevaltokubeconformfor schema validation; among other benefits, the latter can be used as a library, which means that users don't need to install anything extra to run validation checks.The second is not super-well documented yet and may have minor API changes in the future. The initial goal here is to get something basic in place that we can iterate on at at Segment. Later, if that iteration is successful, we can add more details to the README.