test: Loosen Helm test for Helm 3.8.0+ #62
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some of the Helm tests expect the default value of `.Release.Name` to appear in expanded output as all-caps "RELEASE-NAME". Starting in Helm 3.8.0, that default was changed to lowercase "release-name", breaking those tests. The tests now match expected output containing the string in a case-insensitive fashion.
bhavanki
requested review from
alombardo4,
goelshubham and
kevinburkesegment
kevinburkesegment
approved these changes
Nov 14, 2022
alombardo4
approved these changes
Nov 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the Helm tests expect the default value of
.Release.Nametoappear in expanded output as all-caps "RELEASE-NAME". Starting in Helm
3.8.0, that default was changed to lowercase "release-name", breaking
those tests. The tests now match expected output containing the string
in a case-insensitive fashion.