Shuffle some deck chairs around a bit #75
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And enable trimpath
This is a public repo. Segment does not use Buildkite for public repositories, does not publish public images through ECR, and should not push public codebases into private ECR namespaces.
asaf-erlich
approved these changes
Dec 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OK so look... this repository needs attention. There's a lot of organic accumulation here that could maybe stand to see some sunlight and fresh air. But I'm not touching a lot of that. What I am doing is (hopefully) enough remediation work to keep this repository from being a problem until we're fully out of the business of using
kubeapplyfor our infrastructure.Right now, that means:
I'm willing to personally take on the task of moving CI needs for this repo to GitHub Actions in another PR, but my absolute priority right now is ensuring that our
kubeapplylambda deployment continues to work after Sunday, Dec. 31.