Skip to content

Conversation

@bsneed
Copy link
Contributor

@bsneed bsneed commented May 8, 2025

  • Added ability for constructors, methods, getters, setters and functions to throw internally similar to JS implementations.
  • Added ability for JSError's to be created on the native side and interop with JS.
  • Fixed potential retain issue with native class instances.
  • Added mocks and tests.

@codecov
Copy link

codecov bot commented May 8, 2025

Codecov Report

Attention: Patch coverage is 88.88889% with 10 lines in your changes missing coverage. Please review.

Project coverage is 79.86%. Comparing base (a17b5ea) to head (42af47a).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
Sources/Substrata/Internals/Conversion.swift 91.04% 6 Missing ⚠️
Sources/Substrata/Internals/Callbacks.swift 85.71% 2 Missing ⚠️
Sources/Substrata/Internals/Context.swift 85.71% 1 Missing ⚠️
Sources/Substrata/Types.swift 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main       #9      +/-   ##
==========================================
+ Coverage   79.63%   79.86%   +0.22%     
==========================================
  Files          12       12              
  Lines        1537     1604      +67     
==========================================
+ Hits         1224     1281      +57     
- Misses        313      323      +10     
Files with missing lines Coverage Δ
Sources/Substrata/Internals/InternalTypes.swift 86.66% <ø> (ø)
Sources/Substrata/Internals/Context.swift 99.33% <85.71%> (-0.67%) ⬇️
Sources/Substrata/Types.swift 93.10% <50.00%> (-1.15%) ⬇️
Sources/Substrata/Internals/Callbacks.swift 98.37% <85.71%> (-1.63%) ⬇️
Sources/Substrata/Internals/Conversion.swift 72.56% <91.04%> (+1.68%) ⬆️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bsneed bsneed merged commit faf2733 into main May 8, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants