Skip to content

fix: remove snyk, it does not work for this repo and dependabot will do for security #186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 26, 2024
Merged

fix: remove snyk, it does not work for this repo and dependabot will do for security #186

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7562df8
fix: remove snyk, it does not work for this repo and dependabot will …
petedannemann Mar 26, 2024
8e2eda0
add test steps as dependencies for publishing docker images
petedannemann Mar 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 3 additions & 16 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -362,22 +362,9 @@ jobs:
KAFKA_CFG_ADVERTISED_PORT: 9092
KAFKA_CFG_AUTHORIZER_CLASS_NAME: kafka.security.authorizer.AclAuthorizer
KAFKA_CFG_ALLOW_EVERYONE_IF_NO_ACL_FOUND: true

snyk:
runs-on: ubuntu-latest
needs: [test010, test270, test360]
steps:
- uses: actions/checkout@v3
- name: Run Snyk to check for vulnerabilities
uses: snyk/actions/golang@master
env:
SNYK_TOKEN: ${{ secrets.SNYK_TOKEN }}
with:
args: --severity-threshold=high --fail-on=upgradable



publish-ghcr:
needs: [setup, snyk]
needs: [setup, test010, test270, test360]
runs-on: ubuntu-latest
if: ${{ ( github.ref_type == 'branch' ) && (( github.ref_name == 'master' ) || ( github.ref_name == 'v0' )) }}
steps:
Expand Down Expand Up @@ -419,7 +406,7 @@ jobs:
- run: echo "GHCR PUBLISH SUCCESSFUL"

publish-dockerhub:
needs: [setup, snyk]
needs: [setup, test010, test270, test360]
environment: CICD
env:
RELEASE_TAG: ${{ needs.setup.outputs.version-tag }}
Expand Down