Multiple button layouts #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds support for multiple layouts via the ButtonLayout dataclass.
Creates a new AbstractBaseWidget class that is inherited by the button and display of the calculator. It shares common functionality including rebuilding the gui on resize.
Added a wide layout for the calculator that is enabled when the calculator is wider than it is tall.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #3
This pull request refactors GUI code to inherit from a new AbstractBaseWidget class that shares common functionality, including creation and re-creation upon resizing.
It also adds a new ButtonLayout class that can be used to define button layouts for the calculator, as well as two default layouts: LAYOUT_STANDARD_WIDE and LAYOUT_STANDARD_TALL, which are used depending on the aspect ratio of the window.