Skip to content

Update prettier to the latest version 🚀 #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 7, 2017
Merged

Update prettier to the latest version 🚀 #32

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b12197a
chore(package): update prettier to version 1.8.0
greenkeeper[bot] Nov 7, 2017
1990392
style: Update style for Prettier 1.8.0
pvdlg Nov 7, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions lib/load/release-rules.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,9 @@ module.exports = ({releaseRules}) => {
throw new Error('Error in commit-analyzer configuration: rules must be an object with a "release" property');
} else if (RELEASE_TYPES.indexOf(rule.release) === -1) {
throw new Error(
`Error in commit-analyzer configuration: "${rule.release}" is not a valid release type. Valid values are: ${JSON.stringify(
RELEASE_TYPES
)}`
`Error in commit-analyzer configuration: "${
rule.release
}" is not a valid release type. Valid values are: ${JSON.stringify(RELEASE_TYPES)}`
Copy link
Member

@gr2m gr2m Nov 7, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the weirdest update :D I don’t even get the error: https://travis-ci.org/semantic-release/commit-analyzer/builds/298356397#L468 do you know ... why?

Copy link
Member Author

@pvdlg pvdlg Nov 7, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Due to prettier/prettier#3124

It's indeed a bit weird. But it was weird before. The problem with long interpolated strings is that there is rarely a good way to display them. They either overflow or have to be broken somewhere...

Copy link
Member Author

@pvdlg pvdlg Nov 7, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It took me a while to read it as well.
The error reported is basically "Replace current by fixed".
But the string that has to be formatted contains "is not a valid" and "Valid values are" which make it confusing. it feel like those are part of the error explanation, but they are actually part of the current and fixed.

);
}
});
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
"eslint-plugin-promise": "^3.5.0",
"eslint-plugin-standard": "^3.0.1",
"nyc": "^11.1.0",
"prettier": "^1.7.2",
"prettier": "~1.8.0",
Copy link
Member

@gr2m gr2m Nov 7, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you change it intentionally to the ~ range?

Copy link
Member Author

@pvdlg pvdlg Nov 7, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. In order to have this type of issue where a minot release create an issue for a small change in style.
patchshouldn't create any problem. When there is a minor or major Greenkeeper will open a PR so we have time to handle the style change if necessary.

"rimraf": "^2.6.1",
"semantic-release": "^9.0.2",
"sinon": "^4.0.2"
Expand Down