feat: allow generic packages as assets #174 #283
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gitlab allows to add generic packages as assets attached to a release. #174 This is a suggestion to define a list of generics to be published into the generics repository of a project and then to be used as assets for the release.
Similar to
assets,genericscan be either an array of strings or an array of objects.I would limit it to complete file paths (no globs), as (in my understanding) generic packages are limited to one file. (Please correct me if I'm wrong here)
Furthermore
genericsobjects can have the properties,path,label(used for the file path in the generics package URL) and astatus(default or hidden package).I tried to avoid code duplications as good as possible by creating external functions. Could have avoided more, but stopped to maintain readability.
Additionally I added the possibility to debug unit tests in VS Code. I can remove this though, if no editor code should be added in this project.