fix: display default icons and fix URL in success message #342
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonasSchubert
changed the title
fgreinacher
reviewed
Mar 22, 2022
|
Thanks a lot @JonasSchubert! Left a suggestion for you :) |
fgreinacher
reviewed
Mar 23, 2022
fgreinacher
reviewed
Mar 23, 2022
|
@travi Do you have any idea why the tests are not starting anymore? |
Co-authored-by: Florian Greinacher <florian@greinacher.de>
😄 |
This was referenced Mar 24, 2022
travi
approved these changes
Mar 24, 2022
|
🎉 This PR is included in version 8.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
hvanoch
pushed a commit
to hvanoch/semantic-release-gitlab
that referenced
this pull request
Apr 14, 2022
…elease#342) Fixes semantic-release#344 Co-authored-by: Jonas Schubert <jonas.schubert@siemens.com> Co-authored-by: Florian Greinacher <florian@greinacher.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all thanks to @fgreinacher for this nice feature.
We are using it already and I stumpled upon two issues:
%2Fin the URI; this is why I added thedecodeURIComponentFixes #344