docs(labels): add description and link for labels as well as an example #372 #386
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fgreinacher
reviewed
May 30, 2022
fgreinacher
approved these changes
May 30, 2022
There was a problem hiding this comment.
This is very helpful, thanks @JonasSchubert!
Should we add a check to the verify method @fgreinacher ?
I think it's fine to just have it documented. Would probably be hard to detect misuse here. Let's wait and add something in case users keep running into problems.
|
🎉 This PR is included in version 9.3.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As highlighted in #349 we should add a better documentation for the labels.
The official documentation for the labels is, to use a comma-separated list.
This is just defined, but not verified or enforced. Should we add a check to the
verifymethod @fgreinacher ?