fix: check publish props only in verify ones are undefined

Author: pvdlg

index.js

@@ -1,4 +1,4 @@
-const {castArray} = require('lodash');
+const {defaultTo, castArray} = require('lodash');
 const AggregateError = require('aggregate-error');
 const setLegacyToken = require('./lib/set-legacy-token');
 const getPkg = require('./lib/get-pkg');
@@ -16,9 +16,9 @@ async function verifyConditions(pluginConfig, {options: {publish}, logger}) {
     const publishPlugin =
       castArray(publish).find(config => config.path && config.path === '@semantic-release/npm') || {};
 
-    pluginConfig.npmPublish = pluginConfig.npmPublish || publishPlugin.npmPublish;
-    pluginConfig.tarballDir = pluginConfig.tarballDir || publishPlugin.tarballDir;
-    pluginConfig.pkgRoot = pluginConfig.pkgRoot || publishPlugin.pkgRoot;
+    pluginConfig.npmPublish = defaultTo(pluginConfig.npmPublish, publishPlugin.npmPublish);
+    pluginConfig.tarballDir = defaultTo(pluginConfig.tarballDir, publishPlugin.tarballDir);
+    pluginConfig.pkgRoot = defaultTo(pluginConfig.pkgRoot, publishPlugin.pkgRoot);
   }
 
   const errors = verifyNpmConfig(pluginConfig);

test/integration.test.js

@@ -55,6 +55,18 @@ test.serial('Skip npm auth verification if "npmPublish" is false', async t => {
   await t.notThrows(t.context.m.verifyConditions({npmPublish: false}, {options: {}, logger: t.context.logger}));
 });
 
+test.serial('Skip npm token verification if "npmPublish" is false', async t => {
+  delete process.env.NPM_TOKEN;
+  const pkg = {name: 'published', version: '1.0.0', publishConfig: {registry: npmRegistry.url}};
+  await outputJson('./package.json', pkg);
+  await t.notThrows(
+    t.context.m.verifyConditions(
+      {npmPublish: false},
+      {options: {publish: ['@semantic-release/npm']}, logger: t.context.logger}
+    )
+  );
+});
+
 test.serial('Throws error if NPM token is invalid', async t => {
   process.env.NPM_TOKEN = 'wrong_token';
   process.env.DEFAULT_NPM_REGISTRY = npmRegistry.url;