-
Notifications
You must be signed in to change notification settings - Fork 23
Adding new property hasFirstMember. Resolves #549.
#667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
587cc4b
Adding property 'hasFirstMember'
dylan-sa 751eff3
Adding release note for issue 549 - rebasing
dylan-sa ae31b99
Adding prefLabel for 'hasFirstMember'
dylan-sa 6201463
Tweak to 'hasFirstMember' scope note
dylan-sa 11d949b
Tweak to hasFirstMember scopeNote
dylan-sa aa98cf6
Making 'hasFirstMember' an inverse functional property
dylan-sa 10984de
Adding property restriction to formal definition of 'OrderedCollection'
dylan-sa 8ce48ba
Tweak to 'hasFirstMember' scope note regarding multiple first members
dylan-sa File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks nearly perfect. We didn't mention this at the meeting, but it occurs to me you could also add a restriction on
OrderedCollectionto the effect that it is either empty or has a first member. (Note that due to OWA the first member doesn't have to be stated.)A little nitpicky, but most commonly I see the OWA spelled "Open World Assumption" rather than the hyphenated lowercase version, though I know this is also used.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For
OrderedCollection, maybe something like the following would work? If so, should I go ahead and include in this PR?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure I follow; it looks like it is literally saying the following:
Is this your intention? A slightly simpler alternative to complement would be to use max cardinality of 0